[mqtt.homeassistant] Remove newStyleChannels temporary back-compat #17908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes removing deprecated channel IDs controlled by the same flag. Signed-off-by: Cody Cutrer <[email protected]>
|
So you want to merge it this quick? It would make it harder to create patch releases, due to conflicts. Maybe wait for the first patch release to arrive? |
|
I'm fine with waiting a bit. If I do any more enhancements, I'll just base them on top of this commit, and not send a PR until this merges. |
|
As a follow up to the 4.3.0 upgrade notice, you might want to consider a similar 5.0.0 warning. For those who forgot, or skipped a version. |
|
I was already planning on it. Thanks for the reminder. |
lsiepel
added
the
enhancement
ccutrer
added a commit
to ccutrer/openhab-distro
that referenced
this pull request
Jan 2, 2025
See openhab/openhab-addons#17908 Signed-off-by: Cody Cutrer <[email protected]>
DrRSatzteil
pushed a commit
to DrRSatzteil/openhab-addons
that referenced
this pull request
Jan 3, 2025
…penhab#17908) This includes removing deprecated channel IDs controlled by the same flag. Signed-off-by: Cody Cutrer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes removing deprecated channel IDs controlled by the same flag.